SDU-C/D-CIDA-2/3-NEXT-TEMPEL1-V1.0 ================================== Result: Not certified; delta-review of this data set after resolution of liens marked [2] below. Recommendation: =============== Archive this data set with liens resolved sufficient to make this a reasonable "raw" (CODMAC 2) data set. These liens are marked with [2] in the list below. The liens marked [4] should be answered by a new, high-level data set. ######################################################################## Summary: Data set is ready for delta-review; no liens remain to be resolved. Two liens were declined; all other liens are either resolved or found not applicable to this data set. All resolved liens were applied to the existing data set; no new high-level data set is needed or will be provided (2012-05-15; BTCarcich). ######################################################################## Liens ===== Three sections of liens, copied from the original peer review of these data set, are listed below: Unresolved; Resolved; Unresolvable. Within each section, each lien is delimited by a line of seventy-two underscores. The original lien follows the underscores preceded by a single character: "-" for Unresolved liens; "#" for Resolved liens; "?" for Unresolvable liens. The description of the resolution of the lien follows, set off by "DECLINED" for Unresolved liens, by "DONE" for Resolved liens, and by "???" for Unresolvable liens, along with a description as appropriate. ######################################################################## ### Unresolved liens: ######################################################################## ________________________________________________________________________ - data/ancillary/*.tab - TABLEs must have at least 1 COLUMN at the top level. If the intent in using containers is to allow numbering of columns in all *.fmt to start from 1, one workaround is to remove the container around only ^structure = cida_header.fmt, i.e. change OBJECT = CONTAINER NAME = CIDA_HEADER START_BYTE file://localhost/var/folders/4M/4MFJOTKMHheiKP4QLutEtU++-OA/-Tmp-/com.apple .PhotoBooth-T0x1001179c0.tmp.2ZSLlo/4-up%20on%202011-11-12%20at%2019.08.jpg = 1 BYTES = 250 REPETITIONS = 1 DESCRIPTION = "CIDA header" ^STRUCTURE = "CIDA_HEADER.FMT" END_OBJECT = CONTAINER to ^STRUCTURE = "CIDA_HEADER.FMT" (and reset the start byte in ^TABLE) DECLINED: per discussion with PDS. This issue is an inadequacy within the PDS 3 Standard as implemented by PDS, specifically inadequacies in some PDS verification software tools and in the PDS Data Dictionary (PDSDD). The Stardust_NExT Project wrote updated Java code for VTool, along with proposed changes to PDSDD, which would fix this issue, tested and delivered same to PDS for their review. Additionally, PDS-SBN confirmed that NASAView could successfully read and display the ancillary, ISP, non-science, and Tempel 1 data tables as defined by the product labels and format (.fmt) files included in the data set. ________________________________________________________________________ - [4] Add characteristic impact parameters, such as charge yield DECLINED: the CIDA team looked at this issue. Derivation of charge yield can only work for positive spectra. Even so, the target signal is multiplexed with one of the low-sensitivity detector signals and is therefore trunctated in time, so determining charge yield would be very sketchy. Also, after reviewing at the spectra, there is only one spectrum, maybe, to which this technique could possibly be applied. ######################################################################## ### Resolved liens: ######################################################################## ________________________________________________________________________ # [2] In the dataset.cat file, there is a reference to CIDASYS.TXT which should be CDASIS.ASC. DONE ________________________________________________________________________ # [2] In the header.fmt file, provide a meaningful DESCRIPTION for the event time column. DONE: DESCRIPTION enhanced; the lien refers to cida_header.fmt, not header.fmt. ________________________________________________________________________ # [2] The target signal and spectrum should be extracted into separate tables. DONE: extracted target into a separate column from the low-sensitivity signal with which it is multiplexed. ________________________________________________________________________ # [2] Remove the MASS HINT column. DONE: replaced with MASS_ESTIMATE COLUMN per separate lien ________________________________________________________________________ # [4] Calibrated mass spectra are not provided. Is it possible to provide TOF, mass, amplitude and (if possible) identification of mass lines? Or does this need to be a different data set? These are needed for the isp/ and tempel1/ subdirectory. DONE: against the advice of the CIDA Science team, calibrated and manually-checked a and b values have been provided, and the corresponding masses added to the CIDA event tables for TEMPEL 1 and ISP targets. ________________________________________________________________________ # [4] If possible, create spectra that combine measurements from all amplifiers into a single spectrum. DONE: BEST_CHARGE COLUMN added, along with saturation flag. ________________________________________________________________________ # data/ancillary/keep_t20050611_t20110214.tab - For column 1, what checksum algorithm was used? The only description I found: DESCRIPTION = "Checksum of the keepalive data" Many values for this field are negative, which might be wrong. DONE: Investigated this issue, CHECKSUM was found to be correct, documented this in CIDA_KEEPALIVE.FMT file in DESCRIPTION of CHECKSUM COLUMN. ________________________________________________________________________ # catalog/next.cat - Has gaps in the mission phase table. These should be explained, preferably by documenting the idle interstitial days in the phase table. Also check the "Spacecraft Operations Type" values in this table; and it would probably be a good idea to proof everything in the table. - One version ahead of the other datasets'. - line 30 "15.February" -> "15 February" - line 89 "200X" -> "2006" - line 122 "CIDA on" -> "CIDA was on" - line 123 "data taken" -> "data were taken" - line 126 "Performed navigation maneuvers" -> "Navigation maneuvers were performed" - line 142 T is used here for the time of encounter, but E was used in navcam.cat. Please standardize this usage. Also, please define T (or E). - line 166, remove "." after 15 - line 189 "26.March" -> "25 March" - line 192: "earth" -> "Earth" DONE: enhanced the explanation of mission phases; fixed typos. ________________________________________________________________________ # catalog/dataset.cat - line 397 "on on" -> "on" ? Has host ID of "SDU", but this is "N/A" in the instrument file. This discrepancy needs to be resolved. DONE (host ID issue not found) ________________________________________________________________________ # VOLDESC.CAT is missing RECORD_TYPE. DONE ________________________________________________________________________ # catalog/reference.cat - BROWNLEEETAL2003 is missing author F. Horz - After first author, initials precede last name, e.g. for "BELTONETAL2011": REFERENCE_DESC = "Belton, M.J.S., Meech, K.J., Chesley, S., ..." should be REFERENCE_DESC = "Belton, M.J.S., K.J. Meech, S. Chesley, ..." - DUXBURYETAL2004 should be DUXBURYETAL2004B - missing references from other datasets' reference.cat (which may be desired): SEMENOVETAL2004B, ECONOMOUETAL2011, GREENETAL2004, TUZZOLINO1994 DONE ________________________________________________________________________ # catalog/sdu.cat - line 134 "15.February" -> "15 February" DONE ________________________________________________________________________ # aareadme.txt - line 23 "considered and integral" -> "considered an integral" [in all three aareadme.txt files] DONE ######################################################################## ### Unresolvable liens ######################################################################## ________________________________________________________________________ ? catalog/dataset.cat ? Has host ID of "SDU", but this is "N/A" in the instrument file. This discrepancy needs to be resolved. ??? Could not locate the problem described; INSTRUMENT_HOST_ID = SDU ??? for all NExT data sets