DART Radio Science Liens ======================== Data ==== file: overview_data_trk223.txt --> there is a typo “three character string: "dop" indicates it is doppler and rangeg data,” (should be “range” instead of “rangeg”). Documentation ============= file: jhuapl_dart_rs_sis_v01.pdf --> Page 5 Section 2: Replace DRACO references with Radio Science --> Page 5 Section 3: Replace DRACO references with Radio Science --> Page 5-6, Section 4.1: Information on the radio science is provided, including details about the HGA. a. I recommend adding a link to the NAIF bundle where the gimbaled C-Kernels can be accessed, similar to the links provided to the DSN data product SISes later on in the file. Any radio science analysis would need to know the orientation of the spacecraft and position of the HGA to calibrate the phase center to center-of-mass offset by the gimbal. b. No information is given about the telecom system. What radio does DART use? What are the nominal frequencies and turnaround ratios? This could be a good place to add that. Please include the nominal uplink/downlink frequencies, the turnaround ratio (880/740), transponder delay, and antenna phase center locations. --> The text in 4.1 claims to contain ionosphere, troposphere, and weather (trk-2-24) files. The Data Product Overview (4.2) claims ionosphere and troposphere, but not weather. Aside from those being inconsistent with each other, only ionosphere files are present in the data sets. The exclusion of troposphere or weather from the tables in section 4.3.1 suggests that the archive only intends to include ionosphere. However, it is recommended to reference weather and troposphere, which can be done easily. The user can be pointed to the radio science multi-mission archive maintained by the Radio Science Sub-Node and hosted by Geosciences Node (https://pds-geosciences.wustl.edu/radiosciencedocs/urn-nasa-pds-jpl_dsn_mmm/). --> Please reference the LIDs for TRK-2-34 and TRK-2-23 documents in the PDS archive. (https://pds-geosciences.wustl.edu/radiosciencedocs/urn-nasa-pds-radiosci_documentation/ ) --> Please reference documentation for the PDS4 transform tool used to extract binary data. Minor editorial corrections: --> typo in title “ProductSoftware”. --> Section 4.1, paragraph 1. "The files are all formatted in standard ways, documented in a series of Software Interrface Specifications (SIS) noted in Table 1." -> "The files are all formatted in standard ways and documented in a series of Software Interrface Specifications (SIS) noted in Table 1." --> Section 4.1, paragraph 1. "For the final PDS archive, DSN data files are retrieved from the SOC data repository and prepared for delivery by to the Planetary Data System who convert them into PDS 4 format." -> "For the final PDS archive, DSN data files are retrieved from the SOC data repository and prepared for delivery to the Planetary Data System who convert them into PDS 4 format." --> Section 4.1, paragraph 3. "The DART HGA is gimballed. It is the primary antenna of DART that provides most of the RS data collected during in last 30 days of the mission." -> "The DART HGA is gimballed. It is the primary antenna of DART that provides most of the RS data collected during the last 30 days of the mission." --> Section 5.2. "trl234 data are stored in binary format as one or more binary tables." -> "trk234 data are stored in binary format as one or more binary tables." Collection Labels ================= file: 'document_rs/collection_document_rs.xml' --> line 11: The collection LID has the wrong bundle listed. Please change "dart_rs" to "dart". The dart_rs bundle does not exist and I think plans for it have been dropped. --> line 13: The collection matches that of the data_trk234 collection. Please update it to be for this collection. --> Should Didymos be listed as a target? If so, shouldn't Dimorphos as well? EN Review ========= data_maf/* - This LID is unknown to EN. Please send EN the context product sometime. urn:nasa:pds:context:instrument:dart.hga data_maf/.../*.xml - These labels have lid_references to urn:nasa:pds:dart:document_rs:jhuapl_dart_rs_sis_v01.pdf while collection_data_maf.xml has a lid_reference to urn:nasa:pds:dart:document_rs:jhuapl_dart_rs_sis_v01 and the label that (presumably) defines the LID has logical_identifier urn:nasa:pds:dart_rs:document_rs:jhuapl_dart_rs_sis_v01 Please converge on one. The middle one seems most correct. data_trk223/.../*xml - These labels have lid_references to urn:nasa:pds:dart:document_rs:jhuapl_dart_rs_sis_v01.pdf while collection_data_trk223.xml has a lid_reference to urn:nasa:pds:dart:document_rs:jhuapl_dart_rs_sis_v01 and the label that (presumably) defines the LID has logical_identifier urn:nasa:pds:dart_rs:document_rs:jhuapl_dart_rs_sis_v01 Please converge on one. The middle one seems most correct. - Instead of https://, these have http://pds.nasa.gov/pds4/pds/v1/PDS4_PDS_1I00.xsd data_trk234/collection_data_trk234.xml - EN has never seen the LID in this lid_reference, either as a lid_reference of as the LID of a label. Please ensure it does or will exist: urn:nasa:pds:radiosci.documentation:dsn.trk-2-34:2021-06-03 data_trk234/2022/dart_hga_tnf_20220102T030017_v01.xml (and others?) - Some fields have descriptions like <description> Uplink Z-height correction. Values -1.0 to 1.0 are allowed; a value -99.0 indicates invalid. </description> Suggestion: add Special_Constants/invalid_constant, Special_Constants/valid_maximum, Special_Constants/valid_minimum to allow automated checking of values. document_rs/* - This could be ok but probably not. These labels have LIDs urn:nasa:pds:dart_rs:document_rs urn:nasa:pds:dart_rs:document_rs:jhuapl_dart_rs_sis_v01 while this review's other collections have LIDs with :dart: not :dart_rs:, e.g. urn:nasa:pds:dart:document_draco urn:nasa:pds:dart:data_maf:dart_rs_2022_001_2022_002_maf_01 The nominal bundle.xml expects urn:nasa:pds:dart:document_rs document_rs/collection_document_rs.xml - Lines 76-80: <Target_Identification> <name>Dimorphos</name> <type>Asteroid</type> <Internal_Reference> <lid_reference>urn:nasa:pds:context:asteroid.dimorphos</...> Dimorphos should be Satellite, and the last line should be: <lid_reference>urn:nasa:pds:context:target:satellite.65803_didymos.dimorphos</...> If you also want Didymos, add another Target_Identification with <lid_reference>urn:nasa:pds:context:target:asteroid.65803_didymos</...>