DART DRACO v2.0 Liens ===================== Data ==== --> in labels for calibrated *_iof data incorrectly uses unit for _rad data. Correct the unit or, if IOF is unitless, remove this attribute from the IOF labels completely. --> Geometry metadata is absent from the labels and only present in the FITS headers. While the geometry in the headers is not final, having it in the labels makes it easier to update in the future when geometry information is finalized. --> Geometry keyword values: Agreement is good for rh, phase angle, and latitudes to within the precision given in the header key values, but some systematic trend for range and longitude. If turn off light time correction, then all agrees with the precision in the header. Small discrepancy that should not affect the use of data, but better sort out the reason. --> start_date_time and stop_date_time are the same in data labels due to typo in template. file: 'data_dracocal/*/*/*/*.xml' --> There are many examples of the value 513 being used for window2_y_start where the max value is defined as 512. --> --> Ex: data_dracocal/approach/2022/262/dart_0401325228_12877_01_rad.xml --> --> Ex: data_dracocal/cruise/2022/090/dart_0386444960_04314_02_rad.xml --> There are many examples of the value 1024 being used for window2_x_end where the max value is defined as 1023. --> --> Ex: data_dracocal/cruise/2022/090/dart_0386445111_12784_02_rad.xml --> There are many examples of the value 1025 being used for window2_y_end where the max value is defined as 1024. --> --> Ex: data_dracocal/cruise/2022/090/dart_0386444960_04314_02_rad.xml If the value is correct, the DART dictionary should be updated to allow these values. --> In many data labels, the following attributes are empty, which is invalid according to the DART mission dictionary: dart:acquisition_time dart:badpix_invalidation_mode dart:binning dart:current_18vd_supply dart:current_33va_supply dart:current_33vd_supply dart:current_analog_reset_supply dart:detector1_temp dart:detector2_temp dart:exposure_time dart:fpe_temp dart:gain dart:imaging_mode dart:onboard_cal dart:window2_x_end dart:window2_x_start dart:window2_y_end dart:window2_y_start If the values are unavailable, then the attributes need to be nilled (). At present, only dart:acquisition_time is set to nillable in the mission dictionary, so the other attributes would have to be updated in the dictionary to allow this. files: /*_02_* --> Version numbers are embedded in filenames, and product LIDs are based on filenames, which means that v2 products have different LIDs than their v1 counterparts. Different versions of the same product must have the same LID (and are differentiated by their VID). Documentation ============= file: jhuapl_dart_draco_calibration_pipeline_description_v2.pdf --> There are two different "onboard cal tables" but no instruction regarding which one to choose. Documentation or data label should make it clear this depends on timing of observation. --> Section 3.2.5: 25-int = 2186.675 µm, different from previous version of 2186.75 µm. Is there a typo or is this an updated (and better) value to use? file: jhuapl_dart_draco_uncalibrated_calibrated_sis_v2.pdf --> In FITS headers, refdark1 and refdark2 point to the same file. If this is intentional, documentation should explain what this means. --> Fig.8 caption for panel B: The image is mirror flipped across the y-axis instead of x-axis as stated? --> Section 7.4 DRACO Imaging Sequence table: What's the difference between the shaded rows and unshaded rows? (Every other DOY was shaded differently.) Bundle/Collection Labels ======================== file: 'bundle_dart_spacecraft.xml' --> line 17: should be updated to 2023 from 2022. file: 'data_dracocal/collection_data_dracocal.xml' --> line 12: should be "2.0" not "1.0" --> Please add Dimorphos as a target since it was the primary target. file: 'data_dracoraw/collection_data_dracoraw.xml' --> Please add Dimorphos as a target since it was the primary target. file: 'document_draco/collection_document_draco.xml' --> Should Didymos be listed as a target? Target_Identification is only needed in documents if the target is relevant (for example, in the coordinate system documents). EN Review ========= data_dracocal/collection_data_dracocal.xml - The label has lid_reference urn:nasa:pds:dart:data_dracocal:overview_data_dracocal.txt but the actual LID is urn:nasa:pds:dart:data_dracocal:overview_data_dracocal data_dracoraw/collection_data_dracoraw.xml - The label has lid_reference urn:nasa:pds:dart:data_dracoraw:overview_data_dracoraw.txt but the actual LID is urn:nasa:pds:dart:data_dracoraw:overview_data_dracoraw data_dracoraw/final/2022/269/dart_0401930044_04835_01_raw.xml (and others?) - This image in pds4_viewer is very dark. The .fits file has MISPXVAL= -32768 / the value assigned to missing pixels PXOUTWIN= 32767 / Value assigned to pixels outside window2 while the .xml file has -32768 -32767 If the latter flips to 32767 (positive), pds4_viewer shows the image clearly