DIF-E-HRII-3/4-EPOXI-EARTH-V1.0 =============================== o Add a statement to the calinfo.txt file explaining why the mode 5 & 6 files are so much older than the other files. (-3/4- data) + Done. o In -3/4/-.../calib/lindn/hriir_050115_3_1.lbl, the second sentence of the note ("For example,...") is a little awkward, and "plance" should be "plane". + Done and provided a clearer explanation. o Lori has some typos to submit. + Done. o Look for "HD 80606" in the documentation for the -cal- data sets and their HTML pages. This needs to be "HD 80607" everywhere. + Done. All Data Sets ------------- o Data sets which have no errata should have no errata.txt file. (hriv-3/4 is in this state) o Note in the errata.txt file for all data sets the relationship between the SUB_SPACECRAFT_LATITUDE and the aspect angle of the earth's north pole. o Many labels, e.g. dif-e-mri-2-epoxi-earth-v1.0/mv08031818_1000000_001.lbl have FILTER_NUMBER = 4 but that keyword is a CHARACTER FITS Issues (We need to decide how many of these to actually address) - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - o The cal-*-2 data sets need to have a statement about the units for certain FITS keywords (included in the 2 and 3/4 data sets) added to its errata.txt file. + Done. o Myron S. notes that including BZERO & BSCALE forces most FITS readers to do unnecessary floating point math even when they are 0 and 1. Is it possible to omit them in the next version of the data if they have default values? + Not implementing now; possibly for DIXI. o The BUNIT keyword should have a null value (empty quotes) rather than the value "N/A". (next version) + Not implementing now; possibly for DIXI. o Note that the specific coordinate system and epoch for the geometry is not clear in the FITS header. This should be noted in the documentation for this data set and applied to the FITS headers in the next version produced. + Done. Noted in new FITS headers keyword description document (in DI & EPOXI Doc set). o There are numeric flag values (-999, 0) in the FITS headers that should probably be documented to indicate what they are standing in for (missing data, N/A, etc.). + Done. Noted in new FITS headers keyword description document (in DI & EPOXI Doc set). o Myron S. notes that in all the FITS files he examined the flag extension contained nothing but zeroes. If this is correct, it should probably be mentioned in the documentation. + This was a user error resolved during a break at the peer review! o Although there are image and target orientation keywords in the PDS label, there are no WCS coordinates in the FITS headers (although there are keywords that are used to populate the PDS keywords). If a keyword document is supplied, please include an explanation of what these angles are and how to interpret them. (It would be useful to add the WCS keywords in the next version of the FITS headers for FITS users.) + For lien resolution, discussed how to derive WCS values for EPOXI data. Mission may not implement in FITS for DIXI. Documentation ------------- o Need a description of observation precision and limitations in each instrument catalog file. + Done. A bit more info added. o There is an unlabelled table on p 9 of the EPOXI SIS; doesn't show the exoplanet schedule. + Added. o The keyword EPOXI:EARTH_OBSERVER_MID_TIME (FITS keyword EAROBSDT) definition in the EPOXI_SIS is wrong according to the catalog definition and Brian C.'s explanation. + Corrected SIS. o The SIS talks about a "dark" directory that doesn't seem to exist. (It did exist in DI, but doesn't for EPOXI.) + Removed DARK dir. Not yet used for EPOXI. o The EPOXI_SIS refers to the "minimum_exposure_duration" which is never defined. It needs to be. + Done. o Add a note to the label of the epoch_overview PDF document that movies in the PPT version do not translate to PDF and result in black blocks. + Done. Inserted still pics of movies. o "SSBC", an acronym used in the timing document, needs to be defined. + Done. o Add a summary calibration description to the document/ directory that indicates what steps were actually performed and the names of the files used (as they appear in the archive). + Calibration pipeline summary doc *is* there! But added subdirectory names (e.g., BADPIX, BIAS, etc.) used by calib processes. Calibration steps *ARE* listed in dataset.cat!! o Please add a document which defines the keywords and units mentioned in the FITS header. Specifically, we need something that explains to the user how to find the best available target coordinates. + Done. o catalog/epoxi.cat - In the "EPOCh" section where the table of observating dates and targets are specified, change the third entry from "TRES-3 2008-03-06/066 2008-03-06/066" to "TRES-3 2008-03-06/066 2008-03-08/068". + Corrected. o ref.cat: - BALLARDETAL2008 has publication year 2009 - This file has KLAASENETAL2006 = KLAASEN, K.P., M.F. A'HEARN, M. BACA, ..., DEEP IMPACT INSTRUMENT CALIBRATION, REV. SCI. INSTRUM., 79, 091301, 2008, DOI:10.1063/1.2972112. The catalog has KLAASENETAL2006 = KLAASEN, K.P., M. BACA, ..., DEEP IMPACT INSTRUMENT CALIBRATION, OPTICAL ENGINEERING, SUBMITTED 2006. I.e. the year is 2008 not 2006, plus the authors and the journal changed + BALLARDETAL2008 already ingested but published in 2009. KLAASENETAL2006 ingested long ago but took over two years finish. o document/pdsdd_epoxi.ful - NAME = EPOXI:PARTIAL_SATURATED_PIXEL_COUNT -> NAME = "EPOXI:PARTIAL_SATURATED_PIXEL_COUNT" GENERAL_DATA_TYPE = TEXT -> GENERAL_DATA_TYPE = CHARACTER + Corrected. - pdsdd_epoxi.ful has OBJECT = ELEMENT_DEFINITION NAME = "EPOXI:BODY_POSITIVE_POLE_CLOCK_ANGLE" MINIMUM = 360 Many, e.g. dif-cal-hrii-2-epoxi-calibrations-v1.0/hi07122918_1000005_006.lbl, have EPOXI:BODY_POSITIVE_POLE_CLOCK_ANGLE = 271.8173 which causes a vtool error. Should MINIMUM be MAXIMUM? + Yep. Corrected. - pdsdd_epoxi.lbl has RECORD_TYPE = "FIXED_LENGTH" but no FILE_RECORDS So do dif-c_e_x-spice-6-v1.0/dif_hga_071123_081222_bch.lbl & other spice labels + Done. o More SIS problems: SIS (p. 25): the 3rd to 8th datasets have an extra "-OBS" not in the DATA_SET_IDs in the available catalog files or labels. SIS (p.74): ^EXT_FLAGS_QUALITY_HEADER hi07100422_1010100_001.lbl has EXT_QUALITY_FLAGS_HEADER = SIS (p.79): IMAGE_NMBER hi07122918_1000005_006.lbl: EPOXI:IMAGE_NUMBER + Corrected. o hi07122918_1000005_006.lbl: IMAGE object has keywords SCALING_FACTOR and OFFSET, which are not in the SIS (they would be at p.97). Intentional? They're straightforward + Added to SIS.