DIF-C-HRIV-3/4-EPOXI-HARTLEY2-V1.0 ================================= Review Results: Accepted pending lien resolution. Certified. Symbol Key: o = Lien open x = Lien resolved + = Comments (by SAM unless otherwise indicated) Liens ===== x There is a table file in the document/directory listing all the data files. It looks like an index file. It should probably be in the index/ directory, but some reviewers prefer it in the data or document directory. Please move it to the index/directory, but mention in the docinfo.txt file that it exists. + The science image parameter tables are considered documentation for EPOXI. Reviewers for v1.0 and for EPOXI/EPOCh datasets perferred these files in DOCUMENT. We will continue this practice for these EPOXI Hartley2 datasets. o In the calibrated data set in calinfo.txt, the description of the date/time field is confusing because it assumes a user knows what period in the mission the example value ‘020601’ corresponds to, to be able to distinguish it from a file creation time. This needs to be clarified. x In the dataset.cat file, the summary table needs to have dates and day-of-years checked. + Done. Fixed date and DOY values. x In the MRI and HRIV IMAGE label NOTE fields, the word dimension is both misspelled and misused. 'Image slice' or 'plane' would be a better choice. + Done. Only applies to /calib/drkmodel/ in the calibrated MRI and HRIV datasets and to /calib/specmap/ in the calibrated HRII dataset. x In the calibration drkmodel/ directory, the image labels have no units attached to the array elements at all, and the unit included in the NOTE field is not an appropriate unit. This can be fixed by adding a SCALE_FACTOR to perform the conversion, and a UNIT keyword to define the unit. Also, the data structure needs to be a series of two arrays, since the definition is not homogeneous between the two image planes. Also, please add the algorithm to the NOTE field. + Per OGroussin, it does not make sense to provide a scaling_factor and provide new units in the label and FITS file for VIS because the algorithm that's requested (used by the pipeline) would no longer be appropriate. The parameters given in the VIS drkmodel/ files are pertain to physical characteristics of the CCD and the units being used are appropriate. + Added the algorthim to the NOTE field in the PDS label, and used two arrays, instead of one, to define the two parameters in the file. x If possible, add the QE curve for the CCDs to the other documentation or calibration information, as seems most appropriate. + Not applicable to this dataset. QE curves provided by KKlaasen and TFarnham were added to /calib/ of DIF-C-MRI-3/4-EPOXI-HARTLEY2-V1.0. x In the document/ directory, the epoxy_sis.pdf file Table 1 lists some dates as 2010 which should be 2011. (What is the status of this in the documentation set?) Why are these critical documents that were supposedly collected in the best version in the document set being duplicated in the data set document/ subdirectories? They should not be. + Done. Fixed epoxy_sis.pdf. In the past reviewers liked the more relevant documents in /document/ of the EPOXI datasets. We will continue that practice. x In the data set document/ directories, epoxy_inflight_cal_summary.pdf file, there is a reference to "iCar" which, to start with, should be "i Car", and which needs to have the better-known HD number included each time that name is listed. This file should not be in the data set document/ directories (it should be in the document collection). + Done. Noted in the document that 'i Car' is designated as 'HD 79447' in the archived data products. Also noted that the date for the IR extended linearity cal is 2/5-6/2011 (not 2010). x catalog/hriv.cat x Fix outdated wording (e.g., "after EPOCh..."). + Done. x catalog/epoxi.cat x Check frequency that is specified for the IR coma scans for the paragraph about departure imaging E+12 to E+21 days. + Done. LFeaga provided cadences for E-18 hours to E+2 days and for E+12 to E+21 days. x document/pdsdd_epoxi.ful document/pdsdd_epoxi.idx x Add "DEEP IMPACT/EPOXI DOCUMENT COLLECTION V3.0" VOLUME_SET_NAME in pdsdd_epoxi.ful. Then remake pdsdd_epoxi.idx. + Solved lien by deleting the "V3.0" string from VOLUME_SET_NAME in the voldesc.cat file in di-c-hrii_hriv_mri_its-6-doc-set-v3.0. x All copies of /catalog/epoxi.cat Cruise 1, EPOCh Photometry Test: "On 4-9 November 2007, EPOCh photometry tests were performed. During these tests, the HRIV instrument observed a bright (V=9) visual binary star (HD 80607) for 12 continuous hours to check..." However the images were unexpectedly offset by 29 microradian (12.2 arcsec)." Check this conversion. I get 29 microradian = 6.0 arcsec. Which value is correct?? + Done. The correct value of the unexpected offset was 59 microradian per an email from DDeming dated 28 Nov 2007. Corrected that value in epoxi.cat. x epoxi_sis.pdf x Page 27, table, last row, col 2: "...-MRIV-..." should be "...-MRI..."? + Done. Fixed the typo. x Section 4.5: the massive table does not have EPOXI:MAXIMUM, EPOXI:MINIMUM, EPOXI:MEDIAN, EPOXI:STANDARD_DEVIATION, which are in examples earlier in the SIS and in labels such as dif-c-mri-3_4-epoxi-hartley2-v1.0/data/radrev/2010/248/mv10090513_4000000_001_rr.lbl + Done. Added keywords; have same definition as the "derived" keywords (e.g. EPOXI:DERIVED_MINIMUM). x Very minor, so not really a lien, but we should keep the text but remove the yellow highlighting in the HRIIR limitations section of the supporting document file: hartley2_cal_pipeline_summ.pdf. This file is in many of the data sets. The highlighted text was there when LFeaga wrote it to get agreement from the team that those were the correct values. We do not need or want to make that stand out in the archive, so the highlighting should be removed. + Done. x Calinfo.txt gives an example of the file naming convention which is misleading. The effective date of 2005-07-01 examples seems odd in contrast to the other dates. + Done. x 4_violet.lbl description of the filter cut-on wavelength doesn’t correlate to what is actually observed. In fact, it peaks at 330nm, which is before the stated cut-on of 340nm. If this is because this has been convolved with other characteristics, this needs to be clearly explained. + Fixed. Cutoff of 340nm should be ~320nm. Revised value in label. x In the calib/bias directory, the files with dates of "05xxxx" seem to contain less precise data than the files with dates "02xxxx" (integers vs. real numbers). This needs to be investigated, and probably some additional explanation and guidance needs to be provided to users. + Done. Deleted the old 02xxxx files per BCarcich. Not used by the pipeline. x In the label files, there is a reference to "the Deep Impact Instrument calibration document". This needs to be a more precise reference – like to the specific instrument, or the title of the document, or the published reference, or something that a user can resolve to an actual file or publication. + Done. Made the ref. more explicit. x In the calinfo.txt file, the word "gain" is potentially confusing, since this is a non-typical usage. Please add clarification for this in the actual labels. + Done. Adjusted terminology. x For the cross-talk files, it is important to properly rotate the quadrants, but how to do this is not easy to determine. Please add this to the label files as well. + Done. Added description of rotations that BCarich composed to the xtalk labels. x In calib/calinfo.txt - In example used for naming convention, FLAT/HRIVIS_100201_1_1_9.FIT, for 100201, explanation says "Effective date of 2005-07-01; this flat can be applied to data acquired on 2010-02-01T00:00:00 UTC or later". Correct to "Effective date of 010-02-01; …". ALSO, on next line, - 3 should be - 1 (Version 1 of the file for the specified effective date). + Done. Improved the text per TFarnham. x In calib/drkmodel - ALL .lbl files under NOTE, second sentence uses "dimesion" (misspelled dimension). This usage is improper, since it is referring to the two "slices" or "planes" of image cube, not dimension. Needs to be worded better. + Done. Corrected typo and changed to "image planes". x catalog/dataset.cat: Under Data Set Overview, summary table, check for the following errors: x 2010-09-15 is given as day 259, actually 258 + Not applicable. x 2010-09-25 is given as day 269, actually 268 + Done. x Flyby imaging E-18 to E-3 hours, date span should be 2010-11-03/307 to 2010-11-04/308 + Done. x flyby date given as 2010-11-03/307 instead of 2010-11-04/308 + Done. x flyby imaging E+2 hours E+2 days, dates should be 2010-11-04/308 to 2010-11-06/310 + Done. x /calib/adclut/hrivis_000101_1_0.lbl: Label does not correctly define the format of the .tab file. + Done. Fixed the label.