========== DIHI9P_ENC ========== x = Lien resolved - = Lien open ! = Lien will not be resolved. See comment after the lien. + = Comments @ = Fixes made by SAM (not liens) _____________________________________________________________________________ _____________________________________________________________________________ Reviewers: N. Della Russo, A. Cochran See general notes. This data can be archived *only* if the documentation is improved. The reviewers found these data nearly impossible to use. However, several papers, such as the temperature maps, have already been published using these data, so these data should be archived. @ Some of the issues noted below would not have been raised if the reviewers had read the calibration document or the various INFO.TXT files provided in the archive! + Improved various sections in dataset.cat + Improved descriptions of calibration files in calinfo.txt. dataset.cat x Check DOY/exposure ID table. Should match actual data DOYs and exposure IDs. 140 and 144 no data? + Checked DOY/exposure ID table. Calibrated HRII data does not begin until DOY 171. Comment about data for DOYs 140 and 144 in irrelevant. x Note that the stripes in some frames are actually missing data. + Added. x Note that another version of these data, with about a 10% improvement in the calibration of the anti-saturation filter, have been generated since November 2005. + Added. x Note that these data were NOT cleaned because the cosmic ray routine can not handle all cases. The mission expects to deliver cleaned versions of these data as derived data products, most likely as spectral cubes. + Added. X Note that the calibration document describes the version of the calibration pipeline used for these data. These were the best available data as of November 2005. + Added. x Add a note which calls out the document(s) that define where the boresight is pointing. + The keywords BORESIGHT_RIGHT_ASCENSION and DECLINATION in the data labels indicate where the boresight was pointing in space. Also, pointing is addressed by the new HRII encounter pointing summary document by L. Feaga. x Note that the wavelength map changes with temperature; the IR instrument produces a spectral "smile". Therefore, each image has a specific wavelength map. + Added but please read the calibration document!!! x Correct description of the image extensions (the 2nd and 3rd are the same). + Corrected. x Add note to the data set description that there are some deficiencies with these data and point to the new document that discusses this topic. See general notes below. + Added. x Add a note per MA: The background is not properly subtracted in these data. This was corrected in January 2006, after these data were delivered to SBN. + Added. /calib/flat x All values are one. Are these files simply place holders? If so, provide a better description. + Yes, all values are one. These files are place holders to keep the pipeline running smoothly. Added note to calinfo.txt. /calib/bias x All values are one. Are these files simply place holders? If so, provide a better description. + No, all values are zero. These files are place holders to keep the pipeline running smoothly. Added note to calinfo.txt /calib/dark These dark frames for specific exposure IDs: x What are exposure times and/or units (xx per sec) for these frames? This must be defined in the label or in the documentation for these files. Per Tony, these are scaled for temperature and integration time. + Per Tony, the darks were manually scaled for temperature and integration time, so this information is not needed in the data headers or labels. x Are these the actual darks used in the calibration pipeline? Lori thought these dark frames were an intermediate product. + Several image sequences required the use of these sequence-specifid darks. x Are these darks listed in the "processing" section of the FITS headers? If yes, then these files are used by the calibration pipeline and should be included in the archive. + Yes, if these darks were applied by the pipeline, then the filenames are listed in the PROCESSING_HISTORY_TEXT keyword in the data labels. The dark filename is provided on the DARKFN line. /calib/abscalvs x Convert files from from one-dimensional FITS to ASCII or to FITS tables. Modify labels and calinfo.txt accordingly. + Converted /abscalvs files and modified labels and calinfo.txt. /calib/adclut, /decomprs, /psf, and /xtalk x Convert FITS "images" to FITS or ASCII tables. Modify labels and calinfo.txt accordingly. + Converted /adclut, /decomprs, and /xtalk files and modified labels and calinfo.txt. Did not convert /psf because the current implementation provides an excellent map/illustration of the PSF! /calib/gain x Check contents the files; all values are one? Are these files simply place holders to make the calibration pipeline run? The gain FITS headers indicate these may actually be gain corrections. Clarify with the SDC and update documentation and labels accordingly. + Yes, all values are one. Yes, these files provide corrections or adjustments to the gain. Modified the description in the data labels accordingly. /calib/drkmodel x Check contents of the files. Are all of the values are the same? If yes, explain why. Also, should document how /drkmodel vs. /dark files are used in the calibration pipeline. + Each pixel in the dark model files has a different value, as expected. Please(!) read the calibration document. It describes how /darkmodel and /dark files are used in the calibration pipeline. x Consider adding the dark integration time to at least the PDS labels and ideally to the FITS headers. + The darks were manually scaled for temperature and integration time, so this information is not needed in the data headers or labels. /calib/dark x Consider adding the dark integration time to at least the PDS labels and ideally to the FITS headers. + Not implemented. Each dark applies to only one image sequence where all frames have the same integration time, and each dark was manually generated using frames of background sky within an image sequence. Image headers have the integration time. Please read the calibration document!! /calib/psf x Are these files simply dummy files to keep the calibration pipeline running smoothly? Modify documentation accordingly. + Please read the calinfo.txt file!!! It already states that the psf files simply provide a centered delta function to prevent any changes to the data during calibration processing. /data x Bitmaps (supposedly the image quality map for each frame) are all zeros? If true, explain why. + The image quality maps are not all zero. Simply displaying the minimum and maximum values in one image quality map would've shown this! /document x Calibration paper or dataset.cat: The IR calibration documentation MUST be improved for these data to be useful. + The documenation is OK. The users simply need to read the documentation. Added 'Required Reading' section to dataset.cat. x How does one do science on these data? + Added hints in dataset.cat x Identify which data are scientifically useful, what parts/areas of these images have useful info (inside/outside anti-saturation filter), how to register a set of images in one scan, and what is being done to produce a better, calibrated data set. + Addressed in the new HRII calibration limitations document by K. Klaasen and the new HRII encounter pointing summary document by L. Feaga. x Note that all data published to date have been from information outside the anti-saturation filter. + Added note to dataset.cat. x Write a summary of the calibration document. Discuss known deficiencies with the IR calibration and include a description for each type of calibration file included in the archive. + Known defic1encies are discussed in the new HRII calibration limitations document by K. Klaasen. x Calibration paper: Add at least a table of contents to the final version. + Added by K. Klaasen. x How does one locate the target in a spectral image image? Each exposure is a spatial scan with in an exposure ID. The scans often start off the target, then on the target, then off the target. Take Lori's notes about this topic and make another table/document about how to locate the target, including descriptions of each exposure ID scan. This applies to the reduced data set, too. Until the IR context maps for encounter are archived as derived produces, need some method to indicate pointing in the IR encounter images. + Addressed in the new HRII encounter pointing summary document by L. Feaga. General ======= /browse ------- x Click on thumbnail and get a JPEG version of the actual FITS file. Consider linking to the actual FITS file. + Not implemented. The purpose of the browse product is to allow researchers to visually inspect data products. x Add a note that states the JPEG images can be small. During encounter, many VIS images were taken in the 64x64 pixel subframe mode. Consider adding image sizes on the browser pages. + Note added to the browinfo.txt, browse.lbl, and daily index.lbl files. Therefore, image sizes were NOT added on the browser pages. x What is the reduced resolution on the JPEG images? If it is available, document it in at least browinfo.txt. + Clarified text in the browinfo.txt, browse.lbl, and daily index.lbl files. @ Renamed all daily index.html files to index.htm. This is not a lien, but simply a fix to meet PDS standards. @ Renamed browseinfo.txt to browinfo.txt for several data sets. This is not a lien, but simply a fix to meet PDS standards. browse.lbl x Fictional browse object is used; state this object is not currently defined in the PDS. Recommend writing a separate label for each JPEG file. + Replaced the fictional BROWSE object with DOCUMENT. Rewrote labels for browse.html files. Wrote new index.lbl labels to point to the index.htm and JPEG files in each daily browse directory. x Change PDS_VERION_ID from "PDS4" to "PDS3". + Fixed browse.lbl /catalog -------- General x Update mission, instrument host, instrument files with information through encounter. + Updated. x Change references to the relative impact speed from 10.2 to 10.3 km/s; this speed changed to 10.3 because the launch was delayed to Jan 12th (10.2 km/s was for a Jan 1st launch). + Updated mission.cat and dif.cat mission.cat x Check DOYs and start/stop dates provided for each mission phase. + Corrected. x Assuming all calibration targets are renamed to "CALIBRATION", modify the list of mission targets to be only 9P/TEMPEL 1 and CALIBRATION. + Modified. @ Changed AHEARNETAL2005 reference ID to AHEARNETAL2005B. dif.cat @ Changed AHEARNETAL2005 reference ID to AHEARNETAL2005B. reference.cat x Correct AHEARNETAL2005 and AHEARNETAL2005A reference IDs. + Changed AHEARNETAL2005 reference ID to AHEARNETAL2005B. personnel.cat @ Corrected values for NODE_ID and PDS_AFFILIATION for those users associated with PDS. @ Corrected typo "PROPLUSION" to "PROPULSION" dataset.cat x Remove contact names. + Removed x Verify list of observation dates and exposure IDs. Some min/max exposure IDs do not seem to match. Check date ranges, too. + Checked; revised as needed. x Add section for "essential reading" documents (for documents included in the archive). + Added x Add a section for related data sets. For example, for a raw data set, provide a list of associated reduced data sets. + Added. x Add note that horizontal stripping indicates missing data. The image quality map identifies these affected pixels. + Added. x Add note to reduced data sets that calibration frames were not calibrated and are not included in these data sets; Calibration frames are only available in the raw data sets. + Added. x Clarify description of correlation between exposure ID and image number. For example, there can be multiple image numbers for one exposure ID. + Enhanced the 'File Naming Convention' section. x Add a note that the first 100-bytes of a raw image are the spacecraft header bytes. Beware when displaying the images. The mission will not overwrite these bytes in the raw and processed data sets, but will in higher-level products. + Enhanced the 'File Naming Convention' section. Target catalog files x RA and Dec should appear in the files. However, these should disappear in the final archive. Calibration targets will be changed to "Calibration". x In general, why do some parameters in the planetary catalog files have so many decimal places? x Clean up the calibration target catalog files. Recommend changing all calibration-related targets to "CALIBRATION" and adding a new keyword, e.g. ACTUAL_TARGET_NAME, to hold the original value in TARGET_NAME. This affects the product labels and index files for all raw data sets, as well as the target list in the mission.cat, voldesc.cat, and index.lbl files. + The previous three liens are not applicable to this data set. /document --------- ! Subdirectories are by DOY; can YY-MM-DD be included? Or, consider creating a new table that includes DOY, calendar date, exposure ID range for *all* instruments. + No change. Come on folks. *Please* read the dataset.cat file! It provides this information! x Provide a report that discusses the time discrepancy between the spacecraft clocks and how the problem was "resolved" and implemented in the SPICE kernels and the archive. Include this document in the SPICE archive, too. + Provided by B. Carcich. x Write a more detailed html page to present the documents. Need to help users decide which documents are "required reading". + Being written by S. McLaughlin. Also, added a "required reading" section to dataset.cat x Include a document that discusses the known deficiencies with the calibration of the IR spectral data. K. Klaasen (JPL) will write this document. + Provided by K. Klaasen. x Consider extracting a copy of the flow chart calibration pipline, along with the corresponding text, and including it as a "calibration summary" document. Reviewers did not want to read the entire calibration document. x Being composed by S. McLaughlin. x Calibration paper: Add at least a table of contents to the final version. + Added by K. Klaasen. x /document/calibration_pipeline: IDL routines and imbedded comments are adequate for this archive. /calib (for reduced data only) ------ x Convert /abscalvs files from from one-dimensional FITS to ASCII or to FITS tables. Modify labels and calinfo.txt accordingly. x Convert /abscalir, /adclut, /decomprs, /psf, and /xtalk from FITS "images" to FITS or ASCII tables. Modify labels and calinfo.txt accordingly. x Check contents of gain files for all VIS data sets; all values are one? Are these simply place holder files to make the calibration pipeline run? The gain FITS headers indicate these may actually be gain corrections. Clarify with the SDC and update documentation accordingly. x Check contents of dark files for all VIS data sets. Why are all of the values are the same? Are these simply place holder files to make the calibration pipeline run? Need to research with data provider (O. Groussin). Per T. Farnham, each quad of ITS has a different coefficient, but HRIV and MRI have the same coefficient for each quadrant. Therefore, these maps have the same value for all quadrants. Change the description for these files since these are not the "true" gain! + These liens appear at the top of this list; comments provided there. /index ------ index.lbl x Add missing column descriptions. x Correct typo in INDEX_TABLE description: "This index table contain parameters..." x Correct typo in PRISM_TEMP description: "...parameter provides provides the temperature..." x Check for other typos and correct. + All liens for /index resolved. index.tab x Median values match maximum values in all data sets. Why? + Wrong PDS keyword being extracted for median. Corrected. x Table is hard to use and print because it has over 100 columns. Consider removing columns that are typically not necessary for science or break it into multiple parameter tables. + This concern was addressed by adding a column header record to the index.tab file. The index.lbl was adjusted using SBN's addcolhdr tool. indxinfo.txt x The INDEX.TAB description has two occurrences of "provide". + Removed one. /data ----- x Check values of min, max, median keywords in FITS, labels, and index files. IDL and DS9 disagree with values in headers and labels. This may be due to the 100-byte spacecraft header being excluded from the range of values in the FITS headers. May need to explain this in all dataset.cat files. + Checked; Values are correct given that overclock columns and rows are excluded from the values. Added note to dataset.cat. _____________________________________________________________________________ _____________________________________________________________________________ Liens by A.Cochran from email dated 3 April 2006 dataset.cat x Correct plural/singular issues. For example, "A 2-dimensional CCD images in this data set are stored in FITS format" + Fixed. x Correct "The target name in the image labels is set to intended target". Add the word "the" before "intended". + Not applicable to the data set. /catalog target files -------- target files: x The HD 92044 target identifies the "HD 92044 located in the open galactic cluster NGH 3293". Change "NGH" to "NGC". + Not applicable to the data set. _____________________________________________________________________________ _____________________________________________________________________________ Liens by SBN/S.McLaughlin for the DI Data Sets delivered Dec 2005 Affected Raw Data Sets -------------------------------- DIF-CAL-HRII-2-9P-CRUISE-V1.0 DIF-CAL-HRIV-2-9P-CRUISE-V1.0 DIF-CAL-MRI-2-9P-CRUISE-V1.0 DIF-C-HRII-2-9P-ENCOUNTER-V1.0 DIF-C-HRIV-2-9P-ENCOUNTER-V1.0 DIF-C-MRI-2-9P-ENCOUNTER-V1.0 DII-C-ITS-2-9P-ENCOUNTER-V1.0 Affected Calibrated Data Sets -------------------------------- DIF-C-HRII-3/4-9P-ENCOUNTER-V1.0 DIF-C-HRIV-3/4-9P-ENCOUNTER-V1.0 DIF-C-MRI-3/4-9P-ENCOUNTER-V1.0 DII-C-ITS-3/4-9P-ENCOUNTER-V1.0 ======= General ======= Documentation Set ----------------- in the delivery. + Added; Updated docinfo.txt /data/*fit and *lbl ------------------- The following changes require the DI Science Data Center to correct the FITS headers for all raw and processed flight data. PDS labels will need to be regenerated to capture these changes. The revised data sets must be submitted as version 1.0 and will replace the data sets delivered in Dec 2005. x Correct the values for the target-to-earth position and velocity keywords (TAREARRX* and TAREARV*) in the FITS headers. This affects all data sets. x Correct the comments for the TARSUNR* and TARSUNV* keywords. Recommend improving the comments for all of the best geometry keywords to avoid confusion about the direction of the vectors. x Reverse the sign of the TARSCR* and TARSCV* target-to-spacecraft position and velocity in teh FITS headers. The values will then have the same sign as the NOMinal and REConstructed FITS keywords. SBN found the flipped sign in the TARSC* keywords to be confusing. x In the labels, change TARGET_EARTH_POSITION_VECTOR to EARTH_TARGET_POSITION_VECTOR x In the labels, change TARGET_EARTH_VELOCITY_VECTOR to EARTH_TARGET_VELOCITY_VECTOR x In the labels, add SPACECRAFT_GEOCENTRIC_DISTANCE. The source is EARDIST in the FITS headers). x In the labels, correct the value of the TARGET_HELIOCENTRIC_DISTANCE keyword. Currently, it is set to the the spacecraft-to-Earth distance. The correct source is the FITS header keyword TARSUND. + All problems listed above were corrected. /catalog -------- mission.cat x Verify the estimated time-of-impact provided in the labels is noted in the data set description. Consider checking if the science team wants a particular value specified for the mission. The current value was taken from the initial results paper published in Science 2005. + Checked; OK. dataset.cat x Verify the estimated time-of-impact provided in the labels is noted in the data set description. Consider checking if the science team wants a particular value specified for the mission. The current value was taken from the initial results paper published in Science 2005. + Checked; OK. dataset.cat x Shorten data_set_terse_desc to 255 characters; in some cases it is too long. + Length OK; not changed x Verify this note was added to the raw and processed data sets: For encounter images, geometry values relating the target were calculated using the impact site as the origin of the vector. This was the information available in the encounter SPICE SP-kernel delivered by the DI Nav team. The comet center was NOT used when calculating geometry for encounter images. + Added. x Verify the estimated time-of-impact provided in the labels is noted in the data set description. + Verified and noted in data set description. reference.dat + Change AHEARNETAL2005 to AHEARNETAL2005B. Make necessary changes to mission, host, instrument, and dataset.cat files. This referenence is the for SSR chapter "Deep Impact: A Large-Scale Active Experiment on a Cometary Nucleus". + Changed. bethyitarget.cat x EN made a motion to change the target name from "BET HYI" to "BETA HYI". The value "BET HYI" is used the the FITS headers, PDS labels, and index files. However, since the project has been directed to replace all calibration targets with the name "CALIBRATION" in the labels, there is no longer a reason to implement this lien. Additionally, Simbad gives "BET HYI" as the accepted name for this star. + Not applicable to this data set. index.tab and .lbl ------------------ x Change name of column TARGET_EARTH_POSITION_VECTOR to EARTH_TARGET_POSITION_VECTOR + Corrected. x Change name of column TARGET_EARTH_VELOCITY_VECTOR to EARTH_TARGET_VELOCITY_VECTOR + Corrected. x Add column for SPACECRAFT_GEOCENTRIC_DISTANCE + Corrected. x Column 88: Modify the source for, TARGET_HELIOCENTRIC_DISTANCE, to be the value of TARGET_HELIOCENTRIC_DISTANCE in the data labels. Currently, the value for the TARGET_HELIOCENTRIC_DISTANCE keyword in the data labels in not correct (it is the spacecraft-to-Earth distance). + Corrected. x Columns 64-47: Change the NAME suffixes to "COS", "SIN1", "SIN2", and "SIN3", respectively. The original values of "SIN1", "SIN2", "SIN3", a and "COS" are not the correct order. + Corrected. errata.txt ---------- x Update errata.txt after noted /data errors are fixed. + Deleted this file; no longer relevant. ==================== Calibrated Data Sets ==================== /catalog -------- dataset.cat x Verify this note was added for the ENCOUNTER data sets: For encounter images, geometry values relating the target were calculated using the impact site as the origin of the vector. This was the information available in the encounter SPICE SP-kernel delivered by the DI Nav team. The comet center was NOT used when calculating geometry for encounter images. + Added. /calib ------ x Some calibration FITS files must be modified because the FITS format is inapproprite or incorrectly implemented as 'images'. Consider converting the affected files to ASII tables or FITS table extensions without a primary data unit. Modify the labels accordingly to correct the descriptions. Here are the suggested conversions: /calib subdir suggested conversion --------- -------------------------------------------------------------- /abscalvs Ascii text since there are only two values /abscalir Ascii text or FITS table since there are 3 types of values and >3300 entries /adclut For VIS and IR, 16384 entries so use FITS table? /decomprs FITS table? /psf It's a dummy for IR, so toss it. For VIS, ask Jianyang how to make this into an ascii table. /xtalk For VIS and IR, ask Olivier how to make this into an ASCII table? + Done. + These liens are listed at the top of this file; See comments there. x Question for Mark Desnoyer: How are IR adclut (FITS) and decompres tables used? For IR and VIS /decomprs, got 256 samples and 2 lines. What does each line represent? For IR and VIS adclut, what are the 16384 values? + Resolved before the IR adclut and decomprs files were converted to ASCII tables.