DI-C-HRII/HRIV/MRI-ITS-6-DOC-SET-V3.0 ===================================== Review Results: Accepted pending lien resolution. Certification held pending lien resolution. Symbol Key: o = Lien open x = Lien resolved + = Comments (by SAM unless otherwise indicated) Liens ===== x Epoxi_sis.pdf - This is not consistent with the versions of what appear to be the same document found in the data set document/ subdirectories. + TFB4: This is the 20101016 version (pdf, doc, asc, *.png). The other datasets contain the 20110624 pdf version. Need to find all the *.doc, *.asc, *.png for 20110624 version. + SBN (ARaugh) said EPOXI only needed to provide the latest version of the SIS in the PDF/A format, then newer versions of the .doc and .asc format would not be needed. + Done. Copied the latest version of the PDF/A version to this dataset. x There are numerous instances of documents appearing in data set document subdirectories that should be here. This undermines the whole point of having a documentation data set. + TFB4: Doing a 'find' (searching by file name) I found out that only one document is missing: 'dif-cal-hrii_hriv_mri-6-epoxi-temps-v2.0/document/ di_calibration_paper_draft.pdf'. But I found that this file is named 'calibration_paper_draft.pdf' in this dataset. + This "lien" is *NOT* a problem; no revision needed! We simply renamed the DI calibration paper from 'calibration_paper_draft.pdf' to 'di_calibration_paper_draft.pdf' in Doc Set v3.0 to distinguish between it and the calibration summary report for EPOXI/Hartley 2, named 'hartley2_cal_pipeline_summ.pdf'. + Users of archived EPOCh datasets and v1.0 EPOXI calibration datasets liked having the most relevant documents included in DOCUMENT/. Therefore we continue the practice for EPOXI/Hartley 2 datasets. x The calibration paper needs a note added to the label that warns users that a better paper has been published and should now be used for analysis. + Read the label more carefully. It directs the reader to the published DI Instrument Cal paper by Klaasen et al 2008. Reworded the text in the label to make this more obvious. x There are a number of completely empty sections in the calibration software directory *.asc files. This implies we should be filling them in. If that's not going to happen, these sections should be deleted. + Done. One of a readme files for the calibration software had several section headings with no info. Sections are not critical for understanding so deleted them. x In flight_data/epoxi/epoch, all the *geom.* files need to indicate whether coordinates are planetographic or planetocentric. All longitudes appear to be west longitudes. If the coordinates are planetocentric, these should be east longitudes. There also appear to be junk lines of code at the bottom of these files. + Done. Added notes to the files designating types of coords used per email from TLivengood attached below. x In several of the label files there is this sentence: "The team used these values for their analysis although corresponding parameters based on final, reconstructed pointing information are available in the archived data products are based." The last two words need to be deleted all places where this occurs. + Done. x All copies of /catalog/epoxi.cat Cruise 1, EPOCh Photometry Test: "On 4-9 November 2007, EPOCh photometry tests were performed. During these tests, the HRIV instrument observed a bright (V=9) visual binary star (HD 80607) for 12 continuous hours to check pointing and photometric stability...However the images were unexpectedly offset by 29 microradian (12.2 arcsec)." Check this conversion. I get 29 microradian = 6.0 arcsec. Which value is correct?? + Done. The correct value of the unexpected offset was 59 microradian per an email from DDeming dated 28 Nov 2007. Corrected that value in epoxi.cat. x c_di-c-hrii_hriv_mri_its-6-doc-set-v3.0/catalog/ref_epoxi.cat Old, e.g. dif-cal-hrii-2-epoxi-calibrations-v2.0/catalog/ref.cat is better + TFB4: This appears false based on a 'diff'. + Agreed. This lien is not applicable to this dataset. x c_di-c-hrii_hriv_mri_its-6-doc-set-v3.0/voldesc.cat DATA_SET_ID = ..., "DIF-M-HRII-3/4-EPOXI-MARS-V1.0", ... Did PDS EN ever get this dataset? We have no record of it. Many document/*.lbl also refer to it. + This dataset is still in lien resolution. SBN is waiting for the EPOXI project to recalibrate the HRII Mars spectra and redeliver those products. x epoxi_sis.pdf x Page 27, table, last row, col 2: "...-MRIV-..." should be "...-MRI..."? + Done. Fixed the typo. x Section 4.5: the massive table does not have EPOXI:MAXIMUM, EPOXI:MINIMUM, EPOXI:MEDIAN, EPOXI:STANDARD_DEVIATION, which are in examples earlier in the SIS and in labels such as dif-c-mri-3_4-epoxi-hartley2-v1.0/data/radrev/2010/248/mv10090513_ 4000000_001_rr.lbl + Done. Added keywords; have same definition as the "derived" keywords (e.g. EPOXI:DERIVED_MINIMUM). x In the document/ directory, the epoxy_sis.pdf file Table 1 lists some dates as 2010 which should be 2011. (What is the status of this in the documentation set?) Why are these critical documents that were supposedly collected in the best version in the document set being duplicated in the data set document/ subdirectories? They should not be. + Done x In the data set document/ directories, epoxy_inflight_cal_summary.pdf file, there is a reference to "iCar" which, to start with, should be "i Car", and which needs to have the better-known HD number included each time that name is listed. This file should not be in the data set document/ directories (it should be in the document collection). + Done. Added note to doc that "iCar" is "i Car" or "HD 79447". x In the quaternion description document, the terminology used to identify the elements (q0, q1, q2,q3) doesn't match the terminology used in the FITS headers, which refer to "qA, qX, qY, qZ". + This lien belongs to the quaternion.asc file DI&EPOXI Doc Set V3.0! + Done. Edited quaternion.asc in V3.0 Doc Set to include the corresponding FITS header keywords that capture the quaternion. x jd_leapsec.asc in di-c-hrii_hriv_mri_its-6-doc-set-v3.0/document/ archive_support/jd_leapsec/ * ... in some contexts *a of* one day in the integral part ... + Done. x catalog/hrii.cat catalog/hriv.cat catalog/mri.cat x Fix outdated wording (e.g., "after EPOCh..."). + Done. x catalog/epoxi.cat x Check frequency that is specified for the IR coma scans for the paragraph about departure imaging E+12 to E+21 days. + Done. LFeaga provided cadences for E-18 hours to E+2 days and for E+12 to E+21 days. x document/pdsdd_epoxi.ful document/pdsdd_epoxi.idx x Add "DEEP IMPACT/EPOXI DOCUMENT COLLECTION V3.0" VOLUME_SET_NAME in pdsdd_epoxi.ful. Then remake pdsdd_epoxi.idx. + Solved lien by deleting the "V3.0" string from VOLUME_SET_NAME in the voldesc.cat file in di-c-hrii_hriv_mri_its-6-doc-set-v3.0. x In the column description for INSTRUMENT_MODE_ID, recommend adding a note explaining HRII DIAG mode's reset and read frames. These files are affected: di-c-hrii_hriv_mri_its-6-doc-set-v3.0/document/flight_data/epoxi/image_param_tables/ ./hartley2_obs_raw/hrii_2_epoxi_hartley2.lbl ./hartley2_obs_reduced/hrii_3_4_epoxi_hartley2.lbl ./calibrations_raw/hrii_2_epoxi_calibrations.lbl + Done. ======= From: Tim Livengood Date: 31 August 2011 Re: EPOCh geometry files In this table, longitude is west longitude (increasing with time) and latitude is planetographic. The oblateness of Earth is so tiny that the distinction between planetographic and planetocentric latitude is much less than the tenth-of-a-degree resolution used here. West longitude is used here for Earth, since Earth is an ordinary planet for EPOXI, like any other. Each of the quantities that is reported in the table is the median from the four or seven images that was collected on each 15-minute interval. This particular table is lifted from the output I generated in processing lightcurves. There is one of these tables for every observation, regardless of whether the FITS headers included the relevant data -- either the pipeline made the calculation, or I supplied it later. There are look-up tables that I provided for those occasions when the FITS files did not include the descriptive data. In those tables, latitude is planetographic but longitude is East longitude. I believe I supplied each of those tables with a line of code that makes the conversion from East to West longitude. ======